Skip to content

18901-Forgot-password-form-should-not-available-while-customer-is-log…#19029

Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
agorbulin:18901-Forgot-password-form-should-not-available-while-customer-is-logged-in
Nov 6, 2018
Merged

18901-Forgot-password-form-should-not-available-while-customer-is-log…#19029
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
agorbulin:18901-Forgot-password-form-should-not-available-while-customer-is-logged-in

Conversation

@agorbulin
Copy link

@agorbulin agorbulin commented Nov 2, 2018

…ged-in

#18901: Forgot password form should not available while customer is logged in

Description (#18901)

When you is logged in, form forgotpassword not shown, redirect to My Account occurred instead
When you guest and go to forgotpassword form, you see forgotpassword form

Fixed Issues (#18901)

  1. Forgot password form should not available while customer is logged in. #18901: Forgot password form should not available while customer is logged in

Manual testing scenarios (*)

  1. Go to customer/account/forgotpassword as guest
  2. See forgotpassword form
  3. Login as user on FE
  4. Go to customer/account/forgotpassword
  5. You do not see forgotpassword form, but you redirected to My Account

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

18901-Forgot-password-form-should-not-available-while-customer-is-log…
76d478f 
…ged-in

magento#18901: Forgot password form should not available while customer is logged in
@magento-engcom-team magento-engcom-team added Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Component: Customer labels Nov 2, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 2, 2018

Hi @agorbulin. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Nov 2, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 2, 2018

Hi @sidolov, thank you for the review.
ENGCOM-3372 has been created to process this Pull Request

@sidolov sidolov mentioned this pull request Nov 6, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 76d478f into magento:2.3-develop Nov 6, 2018
magento-engcom-team pushed a commit that referenced this pull request Nov 6, 2018
ENGCOM-3372: 18901-Forgot-password-form-should-not-available-while-cu…
99f35e6 
…stomer-is-log… #19029
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 6, 2018

Hi @agorbulin. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@swnsma swnsma mentioned this pull request Nov 6, 2018
Merged
4 tasks
This was referenced Nov 6, 2018
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sidolov sidolov sidolov approved these changes

Assignees

@sidolov sidolov

Labels

Award: bug fix Component: Customer Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.1

Development

Successfully merging this pull request may close these issues.

3 participants

@agorbulin @magento-engcom-team @sidolov